Conversation
| throw new Error("Invalid next player"); | ||
| } | ||
| //if not first move but play on an already played tile | ||
| else if (this._board.TileAt(x, y).Symbol != ' ') { |
There was a problem hiding this comment.
this._board.TileAt(x, y).Symbol content coupling
| // update game state | ||
| this._lastSymbol = symbol; | ||
| this._board.AddTileAt(symbol, x, y); | ||
| } |
There was a problem hiding this comment.
This function is breaking rule one of the SOLID Princple (single responsibility)
There was a problem hiding this comment.
You can list the responsibilities with a name, you can never go bad with an apporach like that, I've came with this two, surely there can be better ones.
Responsibilites in this class:
A) decide winner
B) keep track of the turn
|
|
||
| public Winner() : string { | ||
| //if the positions in first row are taken | ||
| if (this._board.TileAt(0, 0)!.Symbol != ' ' && |
There was a problem hiding this comment.
The internal content is exposed so it can be modified by external classes
We not only can access to the internals of the board but also we have to learn a protocol to interpret it. The convention ' ' means empty tile could really be any convention '_'.
WencesLlobet
left a comment
WencesLlobet
left a comment
There was a problem hiding this comment.
If you want to go deeper in the subjects of last thursday I would suggest on thinking of more inapplicable situations (design pattern, personal project...) like the builder pattern we discussed.
| // update game state | ||
| this._lastSymbol = symbol; | ||
| this._board.AddTileAt(symbol, x, y); | ||
| } |
There was a problem hiding this comment.
You can list the responsibilities with a name, you can never go bad with an apporach like that, I've came with this two, surely there can be better ones.
Responsibilites in this class:
A) decide winner
B) keep track of the turn
|
|
||
| public Winner() : string { | ||
| //if the positions in first row are taken | ||
| if (this._board.TileAt(0, 0)!.Symbol != ' ' && |
There was a problem hiding this comment.
The internal content is exposed so it can be modified by external classes
We not only can access to the internals of the board but also we have to learn a protocol to interpret it. The convention ' ' means empty tile could really be any convention '_'.
2 participants
No description provided.